Skip to content

Space-Time AStar#1170

Merged
AtsushiSakai merged 24 commits into
AtsushiSakai:masterfrom
SchwartzCode:jbs/space_time_astar
Feb 25, 2025
Merged

Space-Time AStar#1170
AtsushiSakai merged 24 commits into
AtsushiSakai:masterfrom
SchwartzCode:jbs/space_time_astar

Conversation

@SchwartzCode

@SchwartzCode SchwartzCode commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Reference issue

What does this implement/fix?

This implements SpaceTime A* as outlined in this paper:
https://www.davidsilver.uk/wp-content/uploads/2020/03/coop-path-AIWisdom.pdf

This is a variant of A* that works with dynamic obstacles. I wanted to implement this to serve as a baseline before implementing Safe Interval Path Planning, which is a clever path planning algorithm that greatly reduces the number of node expansions in problems with dynamic obstacles.

Some examples of the SpaceTime A* algorithm running:

random_scenario

scenario1

Additional information

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

Comment thread PathPlanning/TimeBasedPathPlanning/GridWithDynamicObstacles.py Fixed
Comment thread PathPlanning/TimeBasedPathPlanning/SpaceTimeAStar.py Fixed
Comment thread PathPlanning/TimeBasedPathPlanning/SpaceTimeAStar.py Fixed
@SchwartzCode

Copy link
Copy Markdown
Contributor Author

I didn't find a home for path planning algorithms with dynamic obstacles, let me know if there is somewhere better for this to live :)

I used ruff format to format these files, is there something else I should use?

I also didn't look at all of the CI jobs - will come back to address those tomorrow (it's time for sleep where I'm at)

@AtsushiSakai

AtsushiSakai commented Feb 20, 2025

Copy link
Copy Markdown
Owner

@SchwartzCode Thank you for great PR!! I loved it.

let me know if there is somewhere better for this to live :)

Creating a new directory under here:
https://github.com/AtsushiSakai/PythonRobotics/tree/master/PathPlanning
is fine for me.

I used ruff format to format these files, is there something else I should use?

I think it is enough, but please check all CIs are green.

I also didn't look at all of the CI jobs - will come back to address those tomorrow (it's time for sleep where I'm at)

I think all CIs are running, but some are failed,

image

@SchwartzCode

Copy link
Copy Markdown
Contributor Author

@AtsushiSakai Glad you like the PR! I fixed the CI

@AtsushiSakai AtsushiSakai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. @SchwartzCode I have 2 additional requests.

1
Could you please create a PR to add the gifs for this repository?
https://github.com/AtsushiSakai/PythonRoboticsGifs

2
Is it possible to add documentation for this new script based on the manual?
https://atsushisakai.github.io/PythonRobotics/modules/0_getting_started/3_how_to_contribute.html#step-4-write-a-document-about-the-algorithm

Comment thread PathPlanning/TimeBasedPathPlanning/GridWithDynamicObstacles.py
Comment thread PathPlanning/TimeBasedPathPlanning/GridWithDynamicObstacles.py
Comment thread PathPlanning/TimeBasedPathPlanning/SpaceTimeAStar.py
@SchwartzCode

Copy link
Copy Markdown
Contributor Author

PR into the gifs repo: AtsushiSakai/PythonRoboticsGifs#6

@SchwartzCode

Copy link
Copy Markdown
Contributor Author

Added a short doc entry here: 451e545

@AtsushiSakai AtsushiSakai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have additional comments and questions. PTAL,

Comment thread docs/conf.py Outdated
Comment thread docs/modules/5_path_planning/path_planning_main.rst Outdated
Comment thread PathPlanning/TimeBasedPathPlanning/SpaceTimeAStar.py Outdated
Comment thread PathPlanning/TimeBasedPathPlanning/SpaceTimeAStar.py Outdated

@AtsushiSakai AtsushiSakai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!. @SchwartzCode After, all CIs are green, I will merge this.

@AtsushiSakai AtsushiSakai merged commit 0c8ff11 into AtsushiSakai:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants